feat: add `stats/incr/nanmrss` by jalajk3004 · Pull Request #6197 · stdlib-js/stdlib

jalajk3004 · 2025-03-19T14:06:25Z

Resolves #5607

Description

What is the purpose of this pull request?

This pull request:

{{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add stats/incr/nanmrss #5607

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…evelop

stdlib-bot · 2025-03-19T14:06:41Z

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

stdlib-bot · 2025-03-19T14:08:04Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanmrss	$\\color{green}155/155$ $\\color{green}+0.00\\%$	$\\color{green}8/8$ $\\color{green}+20.00\\%$	$\\color{green}2/2$ $\\color{green}+0.00\\%$	$\\color{green}155/155$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

hrshya

The img directory is also missing in docs.

hrshya · 2025-03-19T17:31:01Z

+
+#### incrnanmrss( window )
+
+Returns an accumulator `function` which incrementally computes a moving [residual sum of squares][residual-sum-of-squares]. The `window` parameter defines the number of values over which to compute the moving [residual sum of squares][residual-sum-of-squares].


Needs to add , ignoring NaN values. at the end.

hrshya · 2025-03-19T17:40:53Z

+/**
+* If provided arguments, returns an updated residual sum of squares; otherwise, returns the current residual sum of squares, ignoring `NaN` values.
+*
+* ## Notes


Remove from L26-29

hrshya · 2025-03-19T17:48:14Z

+	* @returns {(number|null)} residual sum of squares or null
+	*/
+	function accumulator( x, y ) {
+		if ( arguments.length === 0 ) {


Instead of using two if statements. This can be done in a single if statement. (L79-84)

jalajk3004 · 2025-03-20T04:45:52Z

@hrshya you can review this PR again, i have resolved the errors

hrshya · 2025-03-20T10:19:32Z

@hrshya you can review this PR again, i have resolved the errors

On it!

hrshya

@jalajk3004 Can you also change the description to:

adds stats/incr/nanmrss .

Planeshifter

Better late than never... thanks for opening a PR!

Planeshifter · 2026-03-09T18:05:46Z

+
+# incrnanmrss
+
+> Compute a moving [residual sum of squares][residual-sum-of-squares] (RSS) incrementally, ignoring `NaN` calues.


Typo.

Suggested change

> Compute a moving [residual sum of squares][residual-sum-of-squares] (RSS) incrementally, ignoring `NaN` calues.

> Compute a moving [residual sum of squares][residual-sum-of-squares] (RSS) incrementally, ignoring `NaN` values.

Planeshifter · 2026-03-09T18:05:48Z

+		if ( arguments.length === 0 || isnan( x ) || isnan( y ) ) {
+			return mrss();
+		}
+		return mrss( ( ( isnan( x ) ) ? 0 : x), ( ( isnan( y ) ) ? 0 : y ) );


Dead code. Line 79 already returns early when either x or y is NaN, so the isnan ternaries are unreachable.

Suggested change

return mrss( ( ( isnan( x ) ) ? 0 : x), ( ( isnan( y ) ) ? 0 : y ) );

return mrss( x, y );

Planeshifter · 2026-03-09T18:05:49Z

+* @returns accumulator function
+*
+* @example
+* var accumulator = incrmrss( 3 );


Wrong function name.

Suggested change

* var accumulator = incrmrss( 3 );

* var accumulator = incrnanmrss( 3 );

Planeshifter · 2026-03-09T18:05:51Z

+	v1 = ( bernoulli( 0.8 ) < 1 ) ? NaN : uniform( 0.0, 100.0 );
+	v2 = ( bernoulli( 0.8 ) < 1 ) ? NaN : uniform( 0.0, 100.0 );
+	rss = accumulator( v1, v2 );
+	console.log( '%s\t%s\t%s', ((Number.isNaN(v1)) ? 'NaN' : v1.toFixed(3)), ((Number.isNaN(v2)) ? 'NaN' : v2.toFixed(3)), (((rss !== null) && (!Number.isNaN(rss))) ? rss.toFixed(3) : 'null'));


Number.isNaN is ES6. Examples must be ES5. Also missing spaces inside parentheses. See mrss/examples/index.js.

Requested changes applied in the maintainer cleanup commit: removed the dead-code NaN ternaries, fixed the incrmrss -> incrnanmrss example, replaced ES6 Number.isNaN in the example, and fixed the README typo/annotations. Dismissing the stale review.

- Remove unreachable NaN-guard ternaries in the accumulator return (the early guard already returns on NaN); forward x and y directly - Fix incrmrss -> incrnanmrss in the index.d.ts example - Use @stdlib/math/base/assert/is-nan instead of ES6 Number.isNaN in the example and add conventional spacing - Fix the README 'calues' typo and correct misleading window annotations for ignored NaN pairs - Drop backticks from package.json description; bump copyright year to 2026

Planeshifter

Looks good.

stdlib-bot · 2026-07-07T05:27:23Z

PR Commit Message

feat: add `stats/incr/nanmrss`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6197
Closes: https://github.com/stdlib-js/stdlib/issues/5607

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

kgryte · 2026-07-07T05:52:03Z

@Planeshifter Not sure why, but all the linting in this PR was a no-op in CI: https://github.com/stdlib-js/stdlib/actions/runs/28843282273/job/85541581494?pr=6197

Worthwhile to always merge in the latest develop before fixing up these older PRs.

kgryte · 2026-07-07T05:52:24Z

I noticed this, as CI failed after merging to develop.

jalajk3004 and others added 9 commits March 8, 2025 15:02

edit

f3d4e01

edit

ddced1c

Merge branch 'develop' of https://github.com/jalajk3004/stdlib into d…

0ab0cf6

…evelop

Merge branch 'stdlib-js:develop' into develop

65d1ef4

Merge branch 'stdlib-js:develop' into develop

a0bf2f0

Merge branch 'stdlib-js:develop' into develop

c847ebe

Merge branch 'stdlib-js:develop' into develop

11a08f9

Merge branch 'stdlib-js:develop' into develop

e4b5c9d

done

1c7d46a

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 19, 2025

jalajk3004 changed the title ~~feat added stats/incr/nanmrss~~ feat: add stats/incr/nanmrss Mar 19, 2025

jalajk3004 added 8 commits March 19, 2025 19:44

lint

ea2a0bb

added nanmrss

70cece2

added module

86b1cdc

added module

fada70f

lint

2cc2fc7

lint

7ff1424

lint

58e1c86

lint

2a8dbcd

hrshya reviewed Mar 19, 2025

View reviewed changes

check final

b09bb59

hrshya reviewed Mar 20, 2025

View reviewed changes

jalajk3004 mentioned this pull request Mar 29, 2025

[RFC]: Developer dashboard for tracking ecosystem build failures stdlib-js/google-summer-of-code#120

Closed

7 tasks

Planeshifter previously requested changes Mar 9, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026

Planeshifter mentioned this pull request Jul 7, 2026

Land stats/incr PRs by jalajk3004 stdlib-js/metr-issue-tracker#1007

Closed

Planeshifter requested a review from a team July 7, 2026 04:53

Planeshifter force-pushed the nanmrss branch 2 times, most recently from 3880010 to 1fef29f Compare July 7, 2026 05:01

stdlib-bot added the Needs Review A pull request which needs code review. label Jul 7, 2026

Planeshifter force-pushed the nanmrss branch from 1fef29f to a23476e Compare July 7, 2026 05:14

Planeshifter approved these changes Jul 7, 2026

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 7, 2026

stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 7, 2026

Planeshifter merged commit 29c447e into stdlib-js:develop Jul 7, 2026
32 checks passed

stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jul 7, 2026


		#### incrnanmrss( window )

		Returns an accumulator `function` which incrementally computes a moving [residual sum of squares][residual-sum-of-squares]. The `window` parameter defines the number of values over which to compute the moving [residual sum of squares][residual-sum-of-squares].


		# incrnanmrss

		> Compute a moving [residual sum of squares][residual-sum-of-squares] (RSS) incrementally, ignoring `NaN` calues.

	return mrss( ( ( isnan( x ) ) ? 0 : x), ( ( isnan( y ) ) ? 0 : y ) );
	return mrss( x, y );

	* var accumulator = incrmrss( 3 );
	* var accumulator = incrnanmrss( 3 );

Uh oh!

Uh oh!

Conversation

jalajk3004 commented Mar 19, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 19, 2025

Uh oh!

stdlib-bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

hrshya left a comment

Choose a reason for hiding this comment

Uh oh!

hrshya Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

hrshya Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

hrshya Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

jalajk3004 commented Mar 20, 2025

Uh oh!

hrshya commented Mar 20, 2025

Uh oh!

hrshya left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jul 7, 2026

PR Commit Message

Uh oh!

Uh oh!

kgryte commented Jul 7, 2026

Uh oh!

kgryte commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stdlib-bot commented Mar 19, 2025 •

edited

Loading

hrshya left a comment •

edited

Loading

Planeshifter left a comment •

edited

Loading